-
Notifications
You must be signed in to change notification settings - Fork 586
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bumps net-attach-def client to v1.7.3 #1336
Merged
dougbtv
merged 1 commit into
k8snetworkplumbingwg:master
from
dougbtv:net-attach-def-client-v173
Sep 13, 2024
Merged
Bumps net-attach-def client to v1.7.3 #1336
dougbtv
merged 1 commit into
k8snetworkplumbingwg:master
from
dougbtv:net-attach-def-client-v173
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous version didn't account for accounts for the sandox interfaces when reporting the interfaces in the network-status annotation when calculating the default:true interface
maiqueb
approved these changes
Sep 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dougbtv !!!
RamLavi
added a commit
to RamLavi/ovn-kubernetes
that referenced
this pull request
Sep 16, 2024
This reverts commit 14afcbf in order to consume latest multus. This is needed in order to get net-attach-def client v1.7.3 [0] that can intentify the UDN interfaces. [0] k8snetworkplumbingwg/multus-cni#1336 Signed-off-by: Ram Lavi <[email protected]>
RamLavi
added a commit
to RamLavi/ovn-kubernetes
that referenced
this pull request
Sep 16, 2024
This reverts commit 14afcbf in order to consume latest multus. This is needed in order to get net-attach-def client v1.7.3 [0] that can consume the UDN interfaces. [0] k8snetworkplumbingwg/multus-cni#1336 Signed-off-by: Ram Lavi <[email protected]>
RamLavi
added a commit
to RamLavi/ovn-kubernetes
that referenced
this pull request
Sep 17, 2024
This is needed in order to get net-attach-def client v1.7.3 [0] that can consume the UDN interfaces. [0] k8snetworkplumbingwg/multus-cni#1336 Signed-off-by: Ram Lavi <[email protected]>
RamLavi
added a commit
to RamLavi/ovn-kubernetes
that referenced
this pull request
Sep 17, 2024
This is needed in order to get net-attach-def client v1.7.3 [0] that can consume the UDN interfaces. [0] k8snetworkplumbingwg/multus-cni#1336 Signed-off-by: Ram Lavi <[email protected]>
RamLavi
added a commit
to RamLavi/ovn-kubernetes
that referenced
this pull request
Sep 17, 2024
This is needed in order to get net-attach-def client v1.7.3 [0] that can consume the UDN interfaces. [0] k8snetworkplumbingwg/multus-cni#1336 Signed-off-by: Ram Lavi <[email protected]>
jcaamano
pushed a commit
to ovn-kubernetes/ovn-kubernetes
that referenced
this pull request
Sep 18, 2024
This is needed in order to get net-attach-def client v1.7.3 [0] that can consume the UDN interfaces. [0] k8snetworkplumbingwg/multus-cni#1336 Signed-off-by: Ram Lavi <[email protected]>
zeeke
pushed a commit
to zeeke/ovn-kubernetes-us
that referenced
this pull request
Oct 22, 2024
This is needed in order to get net-attach-def client v1.7.3 [0] that can consume the UDN interfaces. [0] k8snetworkplumbingwg/multus-cni#1336 Signed-off-by: Ram Lavi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous version didn't account for accounts for the sandox interfaces when reporting the interfaces in the network-status annotation when calculating the default:true interface